Skip to content

Spacegroup dialog

Jonathan Fisher requested to merge spacegroup-dialog into develop

This branch contains some major changes, so I am submitting a merge request for code review. Summary of main changes:

  • fixed numerical problem in GruberReduction, so it now produces correct results most of the time
  • added tests for determining GruberReduction-
  • fixed what I believe to be a mistake in SpaceGroup::isExtinct (issue #47 (closed))
  • fixed what I believe to be a mistake in UnitCell::isEquivalent (issue #48 (closed))
  • added dialog to choose space group based on Bravais type and forbidden reflections
  • find equivalent reflections based on space group
  • compute R factors based on equivalences

@pellegrini all tests are still passing, but could you please verify that everything is still working correctly on ILL data?

Merge request reports