Skip to content

Bugfix/corrupted dialog convolve

eric pellegrini requested to merge bugfix/corrupted-dialog-convolve into develop

@jmfisher

I performed a massive refactoring of the whole peak find code:

  • merged BlobFinder and PeakFind in a single class
  • merged ConvolutionKernel and Convolver in much cleaner a single interface
  • created Threshold interface for setting to PeakFinder different kind of threshold algorithm
  • added background relative threshold as it seems to be implemented in ILL pfind program
  • added max number of frames peak filtering option as done in pfind
  • added radial convolver
  • added enhanced annular convolver based on your proposition (code to be checked)
  • relocated imaging, convolver and peak find related code in peak_find directory
  • global improvement of peak find dialog
  • fixed long-time bug with preview that was not fitting the whole graphics scene
  • fixed annoying bug with unit tests that were displaying the summary message when nsxqt or pynsx was launched

and I may forget other things ...

IMHO the code is much cleaner now. Could you please review and tell me if it is OK for you ?

Merge request reports

Loading