Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
MDANSE
MDANSE
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Scientific Software
  • MDANSEMDANSE
  • Issues
  • #24

Closed
Open
Opened Jul 06, 2018 by Miguel Angel Gonzalez@gonzalezm
  • Report abuse
  • New issue
Report abuse New issue

Wrong Q vectors in CurrentCorrelationFunction

The Q vectors to use in the calculation of the current correlation function should be the real Q vectors, i.e. (2pi/L)(hkl) for a cubic box and not the normalized ones 2pi(hkl). This can be simply solved by removing the two lines that perform the conversion:

qVectors = traj.universe._boxToRealPointArray(qVectors.T)

qVectors = qVectors.T

Looking to this with Eric, we found that in the DynamicCoherentStructureFactor calculation, there is a double conversion: From real Q vectors to normalized vectors and from real atomic coordinates to fractional coordinates. This is correct, but unnecessary. One can remove both transformations and the result is the same (I checked this).

I will submit a pull request with the suggested changes for both files.

To upload designs, you'll need to enable LFS. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
bug
Assign labels
  • View project labels
Reference: scientific-software/mdanse#24