Fix bug: users do not need to have the token to add/modify/delete

command boxes in simulation tabs.

ChangeLog

+4.0.57 14/08/2020
+------
+* Fix bug: users do not need to have the token to add/modify/delete command boxes in simulation tabs.
+
 4.0.56 13/08/2020
 ------
 * Fix bug: a dnd of a scan containing a settings command box makes other clients crash.

src/main/java/fr/ill/ics/client/control/command/AbstractCommandZone.java

@@ -188,6 +188,7 @@ public abstract class AbstractCommandZone {
 	}
 
 
+	// This method returns false for editors, and true for launch pad AND simulated tabs. 
 	public boolean isServerCommandZone() {
 		return false;
 	}

src/main/java/fr/ill/ics/client/control/command/ModifiableCommandZone.java

@@ -1343,8 +1343,7 @@ public abstract class ModifiableCommandZone extends AbstractCommandZone {
 	public boolean drop(SelectionTreeData selectionTreeData, boolean ctrlActive) {
 		
 		boolean goOn = true;
-
-		if (CommandWindow.getInstance().getCurrentCommandZone().isServerCommandZone()) {
+		if (CommandWindow.getInstance().getCurrentCommandWorkspace().isServerTab()) {
 			if (!TokenManager.getInstance().tokenIsOwnedByMe()) {
 				DialogManager.getInstance().nomadMessageDialog("cannotModifyLaunchPadWithoutTokenMessage", "addToLaunchPadMessage");
 				goOn = false;

src/main/java/fr/ill/ics/client/view/menu/CutCommandAction.java

@@ -32,7 +32,7 @@ public class CutCommandAction implements IMenuAction {
      * Called when a click on the menu item "Cut command" occurs (or when CTRL X is pressed).
      */
     public void execute(boolean checked, int x, int y) {
-		if (CommandWindow.getInstance().getCurrentCommandZone().isServerCommandZone() && !TokenManager.getInstance().tokenIsOwnedByMe()) {
+		if (CommandWindow.getInstance().getCurrentCommandWorkspace().isServerTab() && !TokenManager.getInstance().tokenIsOwnedByMe()) {
 		} else {
 			CommandWindow.getInstance().onCtrlX();
 		}

src/main/java/fr/ill/ics/client/view/menu/EraseEditorAction.java

@@ -33,7 +33,7 @@ public class EraseEditorAction implements IMenuAction {
      * Called when a click on the menu item "Erase editor" occurs (or when CTRL E is pressed).
      */
     public void execute(boolean checked, int x, int y) {
-		if (CommandWindow.getInstance().getCurrentCommandZone().isServerCommandZone() && !TokenManager.getInstance().tokenIsOwnedByMe()) {
+		if (CommandWindow.getInstance().getCurrentCommandWorkspace().isServerTab() && !TokenManager.getInstance().tokenIsOwnedByMe()) {
 		} else {
 	    	MainWindowPeer.getInstance().setCursorToWait();
 	    	MainWindowPeer.setRefresh(false);

src/main/java/fr/ill/ics/client/view/pluginpeer/selection/SelectionTree.java

@@ -94,7 +94,7 @@ public abstract class SelectionTree {
 
 		boolean goOn = true;
 
-		if (CommandWindow.getInstance().getCurrentCommandZone().isServerCommandZone()) {
+		if (CommandWindow.getInstance().getCurrentCommandWorkspace().isServerTab()) {
 			if (!TokenManager.getInstance().tokenIsOwnedByMe()) {
 				DialogManager.getInstance().nomadMessageDialog("cannotModifyLaunchPadWithoutTokenMessage", "addToLaunchPadMessage");
 				goOn = false;