Skip to content

GitLab

Commit 77edb103 authored by Remi Perenon's avatar Remi Perenon
Browse files

Merge branch 'bugfix-rbt_job_fixing' into 'develop' 

Bugfix rbt job fixing

See merge request !37
parents 3b57bc91 46bb6ad4
Pipeline #4367 passed with stages
in 30 minutes and 42 seconds
Show whitespace changes
Inline Side-by-side
CHANGELOG
View file @ 77edb103
......@@ -2,6 +2,7 @@ version 1.2.0
--------------
* ADDED issue #27 Better error handling when an error occurs when running an analysis from the GUI
* ADDED issue #10 Implemented Gromacs trajectory converter
* FIXED issue #35 Result of RBT was incorrect /!\ Modifies job behavior
* FIXED issue #32 Result of DCSF was incorrect (the QVectors changed over frames) /!\ Modifies job behavior
* FIXED issue #31 Result of RMSD was incorrect (the sqrt was not applied) /!\ Modifies job behavior
* FIXED issue #30 Normalization of VACF total value was incorrect /!\ Modifies job behavior
......
Src/Framework/Jobs/RigidBodyTrajectory.py
View file @ 77edb103
......@@ -27,7 +27,7 @@
'''
Created on Jun 9, 2015
:author: Erc C. Pellegrini
:author: Eric C. Pellegrini
'''
import collections
......@@ -60,8 +60,7 @@ class RigidBodyTrajectory(IJob):
settings['trajectory']=('mmtk_trajectory',{})
settings['frames']=('frames', {"dependencies":{'trajectory':'trajectory'}})
settings['atom_selection']=('atom_selection',{"dependencies":{'trajectory':'trajectory'}})
settings['grouping_level']=('grouping_level',{"dependencies":{'trajectory':'trajectory','atom_selection':'atom_selection'}})
settings['stepwise']=('boolean',{'default':True})
settings['grouping_level']=('grouping_level',{"default" : "atom","dependencies":{'trajectory':'trajectory','atom_selection':'atom_selection'}})
settings['reference']=('integer',{"mini":0})
settings['remove_translation']=('boolean',{'default':False})
settings['output_files']=('output_files', {"formats":["netcdf"]})
......@@ -70,99 +69,61 @@ class RigidBodyTrajectory(IJob):
"""
"""
self.numberOfSteps = self.configuration['atom_selection']['selection_length']
self.numberOfSteps = self.configuration['frames']['number']
if (self.configuration['reference']['value'] >= self.configuration['trajectory']['length']):
raise JobError(self,'Invalid reference frame. Must be an integer in [%d,%d[' % (0,self.configuration['trajectory']['length']))
self.nFrames = self.configuration['frames']['number']
self._rbt = {'trajectory':{}}
self._quaternions = numpy.zeros((self.configuration['atom_selection']['selection_length'],self.configuration['frames']['number'], 4),dtype=numpy.float64)
self._coms = numpy.zeros((self.configuration['atom_selection']['selection_length'],self.configuration['frames']['number'], 3),dtype=numpy.float64)
self._fits = numpy.zeros((self.configuration['atom_selection']['selection_length'],self.configuration['frames']['number']),dtype=numpy.float64)
def run_step(self, index):
'''
'''
atoms = sorted(self.configuration['trajectory']['universe'].atomList(), key=operator.attrgetter('index'))
indexes = self.configuration['atom_selection']["indexes"][index]
group = Collection([atoms[idx] for idx in indexes])
rbtPerGroup = {}
# Those matrix will store the quaternions and the CMS coming from the RBT trajectory.
rbtPerGroup['quaternions'] = numpy.zeros((self.configuration['frames']['number'], 4), dtype=numpy.float64)
rbtPerGroup['com'] = numpy.zeros((self.configuration['frames']['number'], 3), dtype=numpy.float64)
rbtPerGroup['fit'] = numpy.zeros((self.configuration['frames']['number'],), dtype=numpy.float64)
rbtPerGroup['trajectory'] = {}
self._groups = []
# Case of a moving reference.
if self.configuration['stepwise']['value']:
for i in range(self.configuration['atom_selection']['selection_length']):
indexes = self.configuration['atom_selection']["indexes"][i]
self._groups.append(Collection([atoms[idx] for idx in indexes]))
# The reference configuration is always the one of the previous frame excepted for the first frame
# where it is set by definition to the first frame (could we think about a cyclic alternative way ?).
for comp in range(self.configuration['frames']['number']):
self.referenceFrame = self.configuration['reference']['value']
if comp == 0:
previousFrame = self.configuration['frames']['value'][0]
trajectory = self.configuration['trajectory']['instance']
self.referenceConfiguration = trajectory.universe.contiguousObjectConfiguration(conf = trajectory.configuration[self.referenceFrame])
else:
previousFrame = self.configuration['frames']['value'][comp-1]
currentFrame = self.configuration['frames']['value'][comp]
refConfig = self.configuration['trajectory']['instance'].configuration[previousFrame]
# The RBT is created just for the current step.
rbt = self.configuration['trajectory']['instance'].readRigidBodyTrajectory(group,
first=currentFrame,
last=currentFrame+1,
skip=1,
reference=refConfig)
# The corresponding quaternions and cms are stored in their corresponding matrix.
rbtPerGroup['quaternions'][comp,:] = rbt.quaternions
rbtPerGroup['com'][comp,:] = rbt.cms
rbtPerGroup['fit'][comp] = rbt.fit
selectedAtoms = Collection()
for indexes in self.configuration['atom_selection']['indexes']:
for idx in indexes:
selectedAtoms.addObject(atoms[idx])
# The simplest case, the reference frame is fixed.
# A unique RBT is performed from first to last skipping skip steps and using refConfig as the reference.
else:
# Create trajectory
self.outputFile = Trajectory(selectedAtoms, self.configuration['output_files']['files'][0], 'w')
# If a fixed reference has been set. We can already set the reference configuration here.
refConfig = self.configuration['trajectory']['instance'].configuration[self.configuration['reference']['value']]
# Create the snapshot generator
self.snapshot = SnapshotGenerator(self.configuration['trajectory']['universe'], actions = [TrajectoryOutput(self.outputFile, ["configuration","time"], 0, None, 1)])
# The RBT is created for the whole frame selection
rbt = self.configuration['trajectory']['instance'].readRigidBodyTrajectory(group,
first=self.configuration['frames']['first'],
last=self.configuration['frames']['last']+1,
skip=self.configuration['frames']['step'],
reference=refConfig)
# The corresponding quaternions and cms are stored in their corresponding matrix.
rbtPerGroup['quaternions'] = rbt.quaternions
rbtPerGroup['com'] = rbt.cms
rbtPerGroup['fit'] = rbt.fit
def run_step(self, index):
'''
'''
# Can not use the centers of mass defined by rbt.cms because the reference frame selected can be out of the selected frames for the Rigid Body Trajectory.
centerOfMass = group.centerOfMass(refConfig)
trajectory = self.configuration['trajectory']['instance']
# Loop over the atoms of the group to set the RBT trajectory.
for atom in group:
currentFrame = self.configuration['frames']['value'][index]
rbtPerGroup['trajectory'][atom.index] = numpy.zeros((self.configuration['frames']['number'],3), dtype=numpy.float64)
for group_id, group in enumerate(self._groups):
# The coordinates of the atoms are centered around the center of mass of the group.
xyz = refConfig[atom] - centerOfMass
rbt = trajectory.readRigidBodyTrajectory(group,
first = currentFrame,
last = currentFrame+1,
skip = 1,
reference = self.referenceConfiguration)
# Loop over the selected frames.
for comp in range(self.configuration['frames']['number']):
centerOfMass = group.centerOfMass(self.referenceConfiguration)
# The rotation matrix corresponding to the selected frame in the RBT.
transfo = Quaternion(rbtPerGroup['quaternions'][comp,:]).asRotation()
transfo = Quaternion(rbt.quaternions[0]).asRotation()
if self.configuration['remove_translation']['value']:
# The transformation matrix corresponding to the selected frame in the RBT.
......@@ -171,67 +132,50 @@ class RigidBodyTrajectory(IJob):
# Compose with the CMS translation if the removeTranslation flag is set off.
else:
# The transformation matrix corresponding to the selected frame in the RBT.
transfo = Translation(Vector(rbtPerGroup['com'][comp,:]))*transfo
transfo = Translation(Vector(self._coms[group_id,index,:]))*transfo
# The RBT is performed on the CMS centered coordinates of atom at.
rbtPerGroup['trajectory'][atom.index][comp,:] = transfo(Vector(xyz))
return index, rbtPerGroup
# Loop over the atoms of the group to set the RBT trajectory.
for atom in group:
# The coordinates of the atoms are centered around the center of mass of the group.
xyz = self.referenceConfiguration[atom] - centerOfMass
atom.setPosition(transfo(Vector(xyz)))
self._quaternions[group_id,index,:] = rbt.quaternions[0]
self._coms[group_id,index,:] = rbt.cms[0]
self._fits[group_id,index] = rbt.fit[0]
self.snapshot(data = {'time' : self.configuration['frames']['time'][currentFrame]})
return index, None
def combine(self, index, x):
"""
"""
self._quaternions[index] = x['quaternions']
self._coms[index] = x['com']
self._fits[index] = x['fit']
self._rbt['trajectory'].update(x['trajectory'])
pass
def finalize(self):
'''
'''
atoms = sorted(self.configuration['trajectory']['universe'].atomList(), key=operator.attrgetter('index'))
selectedAtoms = Collection()
for indexes in self.configuration['atom_selection']['indexes']:
for idx in indexes:
selectedAtoms.addObject(atoms[idx])
# Create trajectory
outputFile = Trajectory(selectedAtoms, self.configuration['output_files']['files'][0], 'w')
# Create the snapshot generator
snapshot = SnapshotGenerator(self.configuration['trajectory']['universe'], actions = [TrajectoryOutput(outputFile, ["configuration","time"], 0, None, 1)])
# The output is written
for comp in range(self.configuration['frames']['number']):
currentFrame = self.configuration['frames']['value'][comp]
self.configuration['trajectory']['instance'].universe.setFromTrajectory(self.configuration['trajectory']['instance'], currentFrame)
for atom in selectedAtoms:
atom.setPosition(self._rbt['trajectory'][atom.index][comp,:])
snapshot(data = {'time' : self.configuration['frames']['time'][comp]})
outputFile.close()
outputFile = NetCDFFile(self.configuration['output_files']['files'][0], 'a')
outputFile.createDimension('NFRAMES', self.configuration['frames']['number'])
outputFile.createDimension('NGROUPS', self.configuration['atom_selection']['selection_length'])
outputFile.createDimension('NFRAMES', self.configuration['frames']['number'])
outputFile.createDimension('QUATERNIONLENGTH',4)
outputFile.createDimension('XYZ',3)
# The NetCDF variable that stores the quaternions.
QUATERNIONS = outputFile.createVariable('quaternion', numpy.dtype(numpy.float64).char, ('NGROUPS', 'NFRAMES','QUATERNIONLENGTH'))
QUATERNIONS = outputFile.createVariable('quaternions', numpy.dtype(numpy.float64).char, ('NGROUPS','NFRAMES','QUATERNIONLENGTH'))
# The NetCDF variable that stores the centers of mass.
COM = outputFile.createVariable('com', numpy.dtype(numpy.float64).char, ('NGROUPS','NFRAMES','XYZ'))
COM = outputFile.createVariable('coms', numpy.dtype(numpy.float64).char, ('NGROUPS','NFRAMES','XYZ'))
# The NetCDF variable that stores the rigid-body fit.
FIT = outputFile.createVariable('fit', numpy.dtype(numpy.float64).char, ('NGROUPS','NFRAMES'))
FIT = outputFile.createVariable('fits', numpy.dtype(numpy.float64).char, ('NGROUPS','NFRAMES'))
outputFile.info = str(self)
......@@ -242,9 +186,9 @@ class RigidBodyTrajectory(IJob):
outputFile.info += 'Group %s: %s\n' % (comp, [index for index in aIndexes])
QUATERNIONS[comp,:,:] = self._quaternions[comp][:,:]
COM[comp,:,:] = self._coms[comp][:,:]
FIT[comp,:] = self._fits[comp][:]
QUATERNIONS.assignValue(self._quaternions[comp,:,:])
COM.assignValue(self._coms[comp,:,:])
FIT.assignValue(self._fits[comp,:])
outputFile.close()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment