LAMP issueshttps://code.ill.fr/scientific-software/lamp/-/issues2020-11-20T13:13:23+01:00https://code.ill.fr/scientific-software/lamp/-/issues/49Reading Figaro NeXus file in Lamp2020-11-20T13:13:23+01:00Miguel Angel GonzalezReading Figaro NeXus file in LampReported by Najib Sharifi (Philipp Gutfreund's user) on 16 Nov 2020. Lamp can read the data, but the wavelength axis is not correctly calculated (NaN).Reported by Najib Sharifi (Philipp Gutfreund's user) on 16 Nov 2020. Lamp can read the data, but the wavelength axis is not correctly calculated (NaN).Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/48SANS-sheet: In log plots, the axis label should be I or Q (not log I or log Q)2020-10-06T14:52:17+02:00Miguel Angel GonzalezSANS-sheet: In log plots, the axis label should be I or Q (not log I or log Q)Noted by Sylvain Prevost.Noted by Sylvain Prevost.Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/47Add log binning to SANS-sheet2020-10-06T14:50:34+02:00Miguel Angel GonzalezAdd log binning to SANS-sheetRequested by Sylvain PrevostRequested by Sylvain PrevostDidier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/44Create D22 new efficiency file2020-10-06T16:09:29+02:00Miguel Angel GonzalezCreate D22 new efficiency fileUse Lionel's file detector_efficiency_det1_ILL_d22_water_Sept_2020.matUse Lionel's file detector_efficiency_det1_ILL_d22_water_Sept_2020.matMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/42Add reading of NeXus files for D162020-07-06T15:23:38+02:00Miguel Angel GonzalezAdd reading of NeXus files for D16Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/40Check default masks for D332020-02-20T10:37:18+01:00Miguel Angel GonzalezCheck default masks for D33See mail from Ralf Schweins from 19 February 2020.See mail from Ralf Schweins from 19 February 2020.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/33Check reading of old data and add unit tests for each file version2019-07-30T12:46:08+02:00Miguel Angel GonzalezCheck reading of old data and add unit tests for each file versionReported by Mark Telling (ISIS) on July 30th 2019, who could not reanalyse old IN16 elastic scans. Checking the problem I found that at some point I had messed up in rdid.pro, so this case (elastic scan with the PSD detector) was not han...Reported by Mark Telling (ISIS) on July 30th 2019, who could not reanalyse old IN16 elastic scans. Checking the problem I found that at some point I had messed up in rdid.pro, so this case (elastic scan with the PSD detector) was not handled correctly. It seems this has been there for a long time (probably since 2014), but apparently not discovered before (or not reported). I am going to implement a quick solution for Mark's case, but ideally, reading of all old data should be checked and introduced as unit tests. I will try to start with IN16 and Salsa, and then continue with other instruments.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/27Possibility to use a workspace to pass a vector of positions (or any other pa...2019-05-13T15:53:54+02:00Miguel Angel GonzalezPossibility to use a workspace to pass a vector of positions (or any other parameter) to str_fitRequested by F. Natali on 9/5/2019. She is trying to repeat a 2D fit while keeping the peak positions previously found fixed, but as only 1 value can be given in the interface for a given parameter, she cannot do it. For this particular ...Requested by F. Natali on 9/5/2019. She is trying to repeat a 2D fit while keeping the peak positions previously found fixed, but as only 1 value can be given in the interface for a given parameter, she cannot do it. For this particular case, this can be solved using a 2D X array and shifting the energy of each spectrum in such a way that the peak is always centred at 0. But it would be nice if one could pass a vector of parameters (one per spectrum) instead of a single value.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/17Add history of relative efficiencies of D33 panels to reading routine2018-06-27T14:42:10+02:00Miguel Angel GonzalezAdd history of relative efficiencies of D33 panels to reading routineOn 27/6/2018, Isabelle Grillo told me that now the relative efficiencies of all the D33 panels are the same. This is handled by the p2p1, p3p1, p4p1 and p5p1 variables in read_hdf.pro. It could be worthy to have a table of values for dif...On 27/6/2018, Isabelle Grillo told me that now the relative efficiencies of all the D33 panels are the same. This is handled by the p2p1, p3p1, p4p1 and p5p1 variables in read_hdf.pro. It could be worthy to have a table of values for different dates in order to be able to read correctly both present and old numors.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/10Str_fit calculation of error in first parameter is wrong when using coolfit2018-05-30T20:35:35+02:00Miguel Angel GonzalezStr_fit calculation of error in first parameter is wrong when using coolfitNeed to check why the estimation of the error of the first fitted parameter is wrong when selecting the coolfit algorithm in str_fit. Fitted values of the parameters are OK, as well as estimated errors for the other parameters. Only erro...Need to check why the estimation of the error of the first fitted parameter is wrong when selecting the coolfit algorithm in str_fit. Fitted values of the parameters are OK, as well as estimated errors for the other parameters. Only error for param 1 is not correct.Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/8Simplify maintenance and building of Lamp.2018-05-30T20:23:52+02:00Miguel Angel GonzalezSimplify maintenance and building of Lamp.Move source code to /home/cs/lamp. Maintain only for IDL > 8.5. Remove instrument plugins and work with a single update file? Continuous integration: Is it possible to build automatically from GitLab? Automatic unit tests? Automatic depl...Move source code to /home/cs/lamp. Maintain only for IDL > 8.5. Remove instrument plugins and work with a single update file? Continuous integration: Is it possible to build automatically from GitLab? Automatic unit tests? Automatic deploy for Linux, Windows and ftp?Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/7New IDL 8.7 version2019-02-15T09:22:59+01:00Miguel Angel GonzalezNew IDL 8.7 versionTest Lamp with latest IDL release (8.7). Check unit tests. Prepare a new runtime.Test Lamp with latest IDL release (8.7). Check unit tests. Prepare a new runtime.Didier RichardDidier Richard