LAMP issueshttps://code.ill.fr/scientific-software/lamp/-/issues2021-07-05T11:52:49+02:00https://code.ill.fr/scientific-software/lamp/-/issues/56scale_d16.pro fails when two scans do not overlap2021-07-05T11:52:49+02:00Miguel Angel Gonzalezscale_d16.pro fails when two scans do not overlapReported and solved by Stef. This is a case that was not foreseen, as the scaling routine assumed that there was always some overlap between the theta regions of two consecutive scans. Now when two consecutive scans do not overlap, the f...Reported and solved by Stef. This is a case that was not foreseen, as the scaling routine assumed that there was always some overlap between the theta regions of two consecutive scans. Now when two consecutive scans do not overlap, the function will use the last and first 5 points of each scan to compute their medians and use those to calculate the scaling factor. This assumes that the intensity in two different theta regions should be the same, so it is not very safe, but the routine will print a warning and it is up to the user to check if the scaling is correct or not.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/55Correct bug in tee for IN16B introduced when "reversing" the energy scale on ...2021-07-05T11:52:29+02:00Miguel Angel GonzalezCorrect bug in tee for IN16B introduced when "reversing" the energy scale on June 27th, 2018Errors are not taking into account, and the command in_wk = reverse(in_wk) modifies also the input workspace, so this has to be corrected.Errors are not taking into account, and the command in_wk = reverse(in_wk) modifies also the input workspace, so this has to be corrected.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/54Update Cosmos to handle new NeXus versions in D17 and Figaro2021-07-05T10:29:56+02:00Miguel Angel GonzalezUpdate Cosmos to handle new NeXus versions in D17 and FigaroMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/53Use NeXus files in Lamp for D172021-07-05T10:30:03+02:00Miguel Angel GonzalezUse NeXus files in Lamp for D17Thomas S. updated rdid_d17.pro to be able to read D17 NeXus files. Check his changes and update lamp to use this new version.Thomas S. updated rdid_d17.pro to be able to read D17 NeXus files. Check his changes and update lamp to use this new version.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/52Update list of cycles for 20212021-07-05T10:30:15+02:00Miguel Angel GonzalezUpdate list of cycles for 2021Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/51Salsa issues2021-03-05T11:05:52+01:00Miguel Angel GonzalezSalsa issuesReported by Thilo Pirling and his post-doc (Ranggi Ramadhan). Two issues:
1. Occasionally (not always), when concatenating an scan (e.g. 37847:37848 from exp 1-02-315, cycle 211) of N steps, the output after calling to straight_1d has N+...Reported by Thilo Pirling and his post-doc (Ranggi Ramadhan). Two issues:
1. Occasionally (not always), when concatenating an scan (e.g. 37847:37848 from exp 1-02-315, cycle 211) of N steps, the output after calling to straight_1d has N+1 steps.
2. Again occasionally, after calling to str_fit the scanned values written in the output seem to be swapped.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/50Implement bug fix found by T. Saerbeck in cosmos_tofpolcorr_two2021-01-25T11:36:53+01:00Miguel Angel GonzalezImplement bug fix found by T. Saerbeck in cosmos_tofpolcorr_twoMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/46Cosmos needs to handle the new chopper installed for cycle 2032021-07-05T10:31:54+02:00Miguel Angel GonzalezCosmos needs to handle the new chopper installed for cycle 203Needs Thomas Saerbeck's codeNeeds Thomas Saerbeck's codeMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/45Correct cosmos_tofpolcorr_two2021-07-05T10:32:06+02:00Miguel Angel GonzalezCorrect cosmos_tofpolcorr_twoMail from Thomas Saerbeck on September 30thMail from Thomas Saerbeck on September 30thMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/43Lamp on IDL 8.8 fails to read the NeXus files2020-10-06T17:55:36+02:00Miguel Angel GonzalezLamp on IDL 8.8 fails to read the NeXus filesWhen trying to read a NeXus file from IN6 (but same happens with other instruments and unit tests), there is an error 'FREE_LUN: Variable is undefined: IN'. Trying to trace back the problem, I found that the function HDx_SD_SELECT return...When trying to read a NeXus file from IN6 (but same happens with other instruments and unit tests), there is an error 'FREE_LUN: Variable is undefined: IN'. Trying to trace back the problem, I found that the function HDx_SD_SELECT returns a LONG in IDL 8.7 and a LONG64 in IDL 8.8.
Note that IDL 8.8 has updated the HDF5 library to 1.10.5 (can this be the origin of the problem?)Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/41Sans_sheet: search alternatively in internalUse when common measurements are ...2021-07-05T10:32:31+02:00Miguel Angel GonzalezSans_sheet: search alternatively in internalUse when common measurements are not found in current folderMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/39Use same FWHM for all the angles when determining the sample bendiness2020-03-03T16:40:28+01:00Miguel Angel GonzalezUse same FWHM for all the angles when determining the sample bendinessSee Thomas Saerbeck's mail from 17 February 2020.See Thomas Saerbeck's mail from 17 February 2020.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/38Check bad peak position occasionally returned by gaussfit in Cosmos2020-03-03T16:39:07+01:00Miguel Angel GonzalezCheck bad peak position occasionally returned by gaussfit in CosmosSee Thomas Saerbeck's mail from 17 February and example table.See Thomas Saerbeck's mail from 17 February and example table.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/37Check and commit changes done by Thomas Saerbeck to cosmos_analysis2020-03-03T16:38:35+01:00Miguel Angel GonzalezCheck and commit changes done by Thomas Saerbeck to cosmos_analysisMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/36Add new QENS model2020-02-27T11:51:12+01:00Miguel Angel GonzalezAdd new QENS modelFrancesca Natali requested a new QENS model consisting of a delta + a lorentzian + a simple random diffusion model.Francesca Natali requested a new QENS model consisting of a delta + a lorentzian + a simple random diffusion model.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/35Update list of cycles for 20202020-01-17T17:39:26+01:00Miguel Angel GonzalezUpdate list of cycles for 2020Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/34Add possibility of using NeXus files in Cosmos2021-07-05T10:32:53+02:00Miguel Angel GonzalezAdd possibility of using NeXus files in CosmosRequested by Thomas Saerbeck on September.Requested by Thomas Saerbeck on September.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/32Use the value of the attenuation coefficient written in the NeXus files in sa...2020-02-20T10:43:23+01:00Miguel Angel GonzalezUse the value of the attenuation coefficient written in the NeXus files in sans_sheetThe attenuators in D11 were changed in 2018. This was taken into account by adding a new table of attenuation values to sans_inst_init.pro and handling the index of each possible attenuator in read_hdf.pro (attenuators 1-3 before 2018 an...The attenuators in D11 were changed in 2018. This was taken into account by adding a new table of attenuation values to sans_inst_init.pro and handling the index of each possible attenuator in read_hdf.pro (attenuators 1-3 before 2018 and attenuators 4-10 in 2018 and afterwards). However, the values in 2019 have changed again so either this has to be extended again (using attenuators 11-17 for 2019) or sans_supl[26] modified to use directly the attenuation coefficient whenever this value is available (this is written in the NeXus files for D11 since cycle 181 and read by read_hdf.pro in parameter 29).
Note that on D22 there are attenuator and attenuator2 and the equivalent field is called attenuation_value.
The same for D33, with the additional complication that when the attenuator is out, the attenuation_value is 0 (instead of 1, as for D22 or D11)Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/31Make 'no raw' mode for D2B to work with new reading/calibration routines2019-07-17T10:02:12+02:00Miguel Angel GonzalezMake 'no raw' mode for D2B to work with new reading/calibration routinesRequested by C. Ritter on 19/6/2019. Now, D2B reading routines use the full tube (instead of the active section 'expanded' to 128 pixels) together with the calibration file generated for the full tube. This works fine with the raw mode, ...Requested by C. Ritter on 19/6/2019. Now, D2B reading routines use the full tube (instead of the active section 'expanded' to 128 pixels) together with the calibration file generated for the full tube. This works fine with the raw mode, but in 'no raw' mode most of the tubes are discarded, as the efficiency of the top and bottom pixels is almost always larger or smaller than the cut-off values (by default 2.5 and 1/2.5). This is a problem when then 'no raw' mode is needed to remove manually a particular tube that has gone bad. There are 2 possible solutions:
1. Take only into account the efficiency of the valid tube section to determine if a tube is bad or not.
2. Skip the automatic removal when a list of tubes to remove is provided by the user.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/30Add monitor handling to Cosmos2019-07-17T10:01:12+02:00Miguel Angel GonzalezAdd monitor handling to CosmosRequested by T. Saerbeck on 19/6/2019.
The possibility to normalize to monitor instead of time seems to have been disabled some time ago, as neither Figaro nor D17 had working monitors. Now D17 has a new monitor, so this option should be...Requested by T. Saerbeck on 19/6/2019.
The possibility to normalize to monitor instead of time seems to have been disabled some time ago, as neither Figaro nor D17 had working monitors. Now D17 has a new monitor, so this option should be reintroduced.Miguel Angel GonzalezMiguel Angel Gonzalez