LAMP issueshttps://code.ill.fr/scientific-software/lamp/-/issues2021-07-05T11:52:29+02:00https://code.ill.fr/scientific-software/lamp/-/issues/55Correct bug in tee for IN16B introduced when "reversing" the energy scale on ...2021-07-05T11:52:29+02:00Miguel Angel GonzalezCorrect bug in tee for IN16B introduced when "reversing" the energy scale on June 27th, 2018Errors are not taking into account, and the command in_wk = reverse(in_wk) modifies also the input workspace, so this has to be corrected.Errors are not taking into account, and the command in_wk = reverse(in_wk) modifies also the input workspace, so this has to be corrected.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/51Salsa issues2021-03-05T11:05:52+01:00Miguel Angel GonzalezSalsa issuesReported by Thilo Pirling and his post-doc (Ranggi Ramadhan). Two issues:
1. Occasionally (not always), when concatenating an scan (e.g. 37847:37848 from exp 1-02-315, cycle 211) of N steps, the output after calling to straight_1d has N+...Reported by Thilo Pirling and his post-doc (Ranggi Ramadhan). Two issues:
1. Occasionally (not always), when concatenating an scan (e.g. 37847:37848 from exp 1-02-315, cycle 211) of N steps, the output after calling to straight_1d has N+1 steps.
2. Again occasionally, after calling to str_fit the scanned values written in the output seem to be swapped.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/50Implement bug fix found by T. Saerbeck in cosmos_tofpolcorr_two2021-01-25T11:36:53+01:00Miguel Angel GonzalezImplement bug fix found by T. Saerbeck in cosmos_tofpolcorr_twoMiguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/49Reading Figaro NeXus file in Lamp2020-11-20T13:13:23+01:00Miguel Angel GonzalezReading Figaro NeXus file in LampReported by Najib Sharifi (Philipp Gutfreund's user) on 16 Nov 2020. Lamp can read the data, but the wavelength axis is not correctly calculated (NaN).Reported by Najib Sharifi (Philipp Gutfreund's user) on 16 Nov 2020. Lamp can read the data, but the wavelength axis is not correctly calculated (NaN).Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/48SANS-sheet: In log plots, the axis label should be I or Q (not log I or log Q)2020-10-06T14:52:17+02:00Miguel Angel GonzalezSANS-sheet: In log plots, the axis label should be I or Q (not log I or log Q)Noted by Sylvain Prevost.Noted by Sylvain Prevost.Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/38Check bad peak position occasionally returned by gaussfit in Cosmos2020-03-03T16:39:07+01:00Miguel Angel GonzalezCheck bad peak position occasionally returned by gaussfit in CosmosSee Thomas Saerbeck's mail from 17 February and example table.See Thomas Saerbeck's mail from 17 February and example table.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/31Make 'no raw' mode for D2B to work with new reading/calibration routines2019-07-17T10:02:12+02:00Miguel Angel GonzalezMake 'no raw' mode for D2B to work with new reading/calibration routinesRequested by C. Ritter on 19/6/2019. Now, D2B reading routines use the full tube (instead of the active section 'expanded' to 128 pixels) together with the calibration file generated for the full tube. This works fine with the raw mode, ...Requested by C. Ritter on 19/6/2019. Now, D2B reading routines use the full tube (instead of the active section 'expanded' to 128 pixels) together with the calibration file generated for the full tube. This works fine with the raw mode, but in 'no raw' mode most of the tubes are discarded, as the efficiency of the top and bottom pixels is almost always larger or smaller than the cut-off values (by default 2.5 and 1/2.5). This is a problem when then 'no raw' mode is needed to remove manually a particular tube that has gone bad. There are 2 possible solutions:
1. Take only into account the efficiency of the valid tube section to determine if a tube is bad or not.
2. Skip the automatic removal when a list of tubes to remove is provided by the user.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/28Correct error in QENS_Fixed_JumpsNsitesLogNormDist model2019-05-29T13:02:49+02:00Miguel Angel GonzalezCorrect error in QENS_Fixed_JumpsNsitesLogNormDist modelReported by Aleksandra Pajzderska on May 28th 2019. Setting P3 = 0 (which should be the msd in the DW factor) makes S(Q,w) = 0!Reported by Aleksandra Pajzderska on May 28th 2019. Setting P3 = 0 (which should be the msd in the DW factor) makes S(Q,w) = 0!Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/24Solve problems in new event_file (VALID_NUM and red_d22.cal) and improve usab...2019-02-15T19:04:35+01:00Miguel Angel GonzalezSolve problems in new event_file (VALID_NUM and red_d22.cal) and improve usabilityValid_num was added as part of an option to select 'manually' the triggers to use when binning the data, but tests done on 22/11/2018 with data from experiment 9-10-1526 (cycle 183) failed. Additionally, the stretching of the tubes using...Valid_num was added as part of an option to select 'manually' the triggers to use when binning the data, but tests done on 22/11/2018 with data from experiment 9-10-1526 (cycle 183) failed. Additionally, the stretching of the tubes using the file 'red_d22_tube_peak_fit_det.dat' is not needed with the new electronics. The export fails now because the file is not present, so this has to be changed.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/21Cosmos does not read the numors in linux computers2019-02-15T19:00:49+01:00Miguel Angel GonzalezCosmos does not read the numors in linux computersThe problem is the same as for issue 20 for D11. The behaviour of the IDL function file_test has changed with the new serdon, so needs to modify all calls in cosmos to file_test and remove the /read option.The problem is the same as for issue 20 for D11. The behaviour of the IDL function file_test has changed with the new serdon, so needs to modify all calls in cosmos to file_test and remove the /read option.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/20Lamp reads ASCII files (instead of reading NXS by default) on D11 linux computer2019-02-15T19:00:15+01:00Miguel Angel GonzalezLamp reads ASCII files (instead of reading NXS by default) on D11 linux computerReported by Ralf Schweins on 4 September 2018, as a bug in the sans_log function.
The problem is that the test done in rdid.pro by the function file_test(pthv+FILENAME+order[0], /READ) returns 0 instead of 1.
The file exists and removin...Reported by Ralf Schweins on 4 September 2018, as a bug in the sans_log function.
The problem is that the test done in rdid.pro by the function file_test(pthv+FILENAME+order[0], /READ) returns 0 instead of 1.
The file exists and removing the /READ option, things work.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/18Error in choice of groups in sgroup2020-02-27T13:35:15+01:00Miguel Angel GonzalezError in choice of groups in sgroupReported by Judith Peters on 2nd July 2018. When using sgroup with IN16 data (from 2009), the last four groups are equal and do not even correspond to the last detector. Need to check the logic when N_detectors / number_of_detectors_in_a...Reported by Judith Peters on 2nd July 2018. When using sgroup with IN16 data (from 2009), the last four groups are equal and do not even correspond to the last detector. Need to check the logic when N_detectors / number_of_detectors_in_a_group is not integer!Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/15Get a suggestion for scales and Q ranges not working for a few samples2020-02-20T10:45:21+01:00Miguel Angel GonzalezGet a suggestion for scales and Q ranges not working for a few samplesReported by Ralf Schweins on 12th June 2018.
Ralf found that after running this table (see image), the button 'Get a suggestion for Scales and Q ranges, calculated from selected samples' did not do anything (i.e. low and high boxes rema...Reported by Ralf Schweins on 12th June 2018.
Ralf found that after running this table (see image), the button 'Get a suggestion for Scales and Q ranges, calculated from selected samples' did not do anything (i.e. low and high boxes remain blank and no scaling is done). I checked this and found that he was right, but that it was not the case for all the samples. E.g., selecting sample 3 things work as expected. Doing the scaling using all samples also work. When trying in my windows PC, I get a similar behaviour, but now the 'low' box is filled and the low-Q curve scaled, and only the high-Q remains irresponsive (see figure).
Need to check what's going on! Could it be related with the selection of Q-ranges and overlapping zones?
![table](/uploads/a72abb1541000c5f8f4a4a0cabc4d08f/table.png)
![results](/uploads/6390889d077fd0f02ff4b960f5e0d842/results.png)Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/14Improvements to polarized data reduction in Cosmos2019-02-15T18:55:12+01:00Miguel Angel GonzalezImprovements to polarized data reduction in CosmosReported by Thomas Saerbeck on 6th June 2018.
The function cosmos_anal_group_pol is not used!
The integer peak position of the reflected beam can be slightly different in the numors corresponding to the different polarizabilities. This...Reported by Thomas Saerbeck on 6th June 2018.
The function cosmos_anal_group_pol is not used!
The integer peak position of the reflected beam can be slightly different in the numors corresponding to the different polarizabilities. This creates a shift when using the coherent method, as the pixel used as the reference to do the 'Q-matching' is not the same. Need to do a similar thing as what it was already done to store the values of Q, dQ, and wavelength and other parameters using the 1st numor as the reference and then employing the same values for the other numors.
It can be tested using table exp_5-54-244/e-fe2o3reduction_win and comparing lines 58, 61 and 7.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/13Update Git and plugins with Cosmos corrections done by Thomas Saerbeck2019-02-15T18:54:51+01:00Miguel Angel GonzalezUpdate Git and plugins with Cosmos corrections done by Thomas SaerbeckThomas Saerbeck modified the resolution calculation in the polarized mode. Push his changes into Git and create a new Cosmos version with the corrected calculation and the corresponding plugin for external users.
Mails from Thomas on 4t...Thomas Saerbeck modified the resolution calculation in the polarized mode. Push his changes into Git and create a new Cosmos version with the corrected calculation and the corresponding plugin for external users.
Mails from Thomas on 4th June 2018:
"I noticed a difference in the resolution calculation depending on whether the reduction is performed individually of within polarized mode. I am currently looking into this, but maybe you can have a look as well.
The runnumbers are (in experiment 5-54-248, currently running)
DB: 417633
Ref pol 00: 417636+417640
Ref pol 11: 417637+417641
Reducing 417636+417640 gives a final resolution of about 4.2%, while reducing 417636+417640p417637+417641 gives a final resolution of about 1.8%. This surprises me, as the resolution calculation for polarized runs should be based on the first (00) runnumbers and therefore be the same. "
"I found the issue, which was a remainder of the time where the resolution calculation was different between the spin channels. Basically back then I had to remove the om-fwhm in the calculation since this always caused a different resolution to be calculated. This seems to be fixed now. I will include the changes in the COSMOS in the figaro folder."Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/12Lamp-SANS: High-angle curve goes up when no default water is present2020-02-20T10:44:39+01:00Miguel Angel GonzalezLamp-SANS: High-angle curve goes up when no default water is presentReported by Sylvain Prevost on 31 May 2018. See table and figure attached.
Data in internalUse (cycle 182)
![table](/uploads/318be55e177fab9c02d2aef72238bb90/table.png)![result](/uploads/014dec68cd4ae2634c49b358b6fa697e/result.png)Reported by Sylvain Prevost on 31 May 2018. See table and figure attached.
Data in internalUse (cycle 182)
![table](/uploads/318be55e177fab9c02d2aef72238bb90/table.png)![result](/uploads/014dec68cd4ae2634c49b358b6fa697e/result.png)Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/11Lamp-SANS: High-angle curve bends upwards2020-02-20T10:45:46+01:00Miguel Angel GonzalezLamp-SANS: High-angle curve bends upwardsReported by Ralf Schweins on 31 May 2018.
A standard treatment table gives I(Q) curves that bend upwards at high Q (see figures).
Experiment 9-11-1876 (cycle 182)
![table](/uploads/341c68024d72cdb51087d5ce1c6f6474/table.png)![result](/...Reported by Ralf Schweins on 31 May 2018.
A standard treatment table gives I(Q) curves that bend upwards at high Q (see figures).
Experiment 9-11-1876 (cycle 182)
![table](/uploads/341c68024d72cdb51087d5ce1c6f6474/table.png)![result](/uploads/b11e77a25e5a32fc352f148625a93475/result.png)Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/10Str_fit calculation of error in first parameter is wrong when using coolfit2018-05-30T20:35:35+02:00Miguel Angel GonzalezStr_fit calculation of error in first parameter is wrong when using coolfitNeed to check why the estimation of the error of the first fitted parameter is wrong when selecting the coolfit algorithm in str_fit. Fitted values of the parameters are OK, as well as estimated errors for the other parameters. Only erro...Need to check why the estimation of the error of the first fitted parameter is wrong when selecting the coolfit algorithm in str_fit. Fitted values of the parameters are OK, as well as estimated errors for the other parameters. Only error for param 1 is not correct.Didier RichardDidier Richardhttps://code.ill.fr/scientific-software/lamp/-/issues/6Inverse energy axis in IN16B2019-02-15T18:50:23+01:00Miguel Angel GonzalezInverse energy axis in IN16BReported by Bjorn Fak on 29/5/2018, confirmed by Bernhard Frick.
The energy axis in IN16B is inverted with respect to the usual convention (E>0, sample energy gain). This is not noticeable in usual experiments, but Bjorn did a dilution e...Reported by Bjorn Fak on 29/5/2018, confirmed by Bernhard Frick.
The energy axis in IN16B is inverted with respect to the usual convention (E>0, sample energy gain). This is not noticeable in usual experiments, but Bjorn did a dilution experiment where the effect is clear.Miguel Angel GonzalezMiguel Angel Gonzalezhttps://code.ill.fr/scientific-software/lamp/-/issues/1Text in STR_FIT (above the plotting window) does not appear in Ubuntu 162019-05-27T15:39:49+02:00Miguel Angel GonzalezText in STR_FIT (above the plotting window) does not appear in Ubuntu 16Reported by B. Frick on 29/5/2018
![Screenshot_strfit](/uploads/5ad702bd6fc121b4b552fdf2b65c67ea/Screenshot_strfit.png)Reported by B. Frick on 29/5/2018
![Screenshot_strfit](/uploads/5ad702bd6fc121b4b552fdf2b65c67ea/Screenshot_strfit.png)Didier RichardDidier Richard