nomad-3d-viewer issueshttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues2022-06-09T17:43:54+02:00https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/15Check connection in client2022-06-09T17:43:54+02:00yannick legocCheck connection in clientIt is important to notify the user when the connection is lost (timeout?).It is important to notify the user when the connection is lost (timeout?).https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/14GUI with golden layout2022-03-25T17:23:42+01:00yannick legocGUI with golden layoutSuggestion:
```
|-----------------|----------|
| view 1 | view 2 | settings |
| view 3 | view 4 | |
|----------------------------|
```Suggestion:
```
|-----------------|----------|
| view 1 | view 2 | settings |
| view 3 | view 4 | |
|----------------------------|
```https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/13Use the size of the BB of a component to determine the resolution of VHACD2022-01-11T11:14:19+01:00yannick legocUse the size of the BB of a component to determine the resolution of VHACDhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/12Change the merge criteria to generate more convex parts2022-01-07T15:32:27+01:00yannick legocChange the merge criteria to generate more convex partsTo obtain a better convex decomposition could be done by segmenting into more parts.
Rather than merging into the biggest possible parts (until an axis is found), merge into smaller parts.
The criteria has to be found.To obtain a better convex decomposition could be done by segmenting into more parts.
Rather than merging into the biggest possible parts (until an axis is found), merge into smaller parts.
The criteria has to be found.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/11Review what is stored in IndexedDB2021-11-15T16:40:33+01:00yannick legocReview what is stored in IndexedDBThe configuration should not be stored in IndexedDB.The configuration should not be stored in IndexedDB.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/10Server performance2021-11-04T09:39:29+01:00yannick legocServer performanceVerify that the requests are executed asynchronously and verify the parallelization of the code e.g. two position requests on two Nomad servers.Verify that the requests are executed asynchronously and verify the parallelization of the code e.g. two position requests on two Nomad servers.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/9Calculate optimized BB in merger2021-04-22T11:19:01+02:00yannick legocCalculate optimized BB in mergerOrient the coordinates of a merge by optimizing the BBOrient the coordinates of a merge by optimizing the BBhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/8StreamDispatcher review2021-04-22T11:17:01+02:00yannick legocStreamDispatcher reviewImprove the StreamDispatcher: add chunk between each data chunk to determine the end or not of the data.Improve the StreamDispatcher: add chunk between each data chunk to determine the end or not of the data.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/7Websocket for positions publication in Nomad module2021-11-04T14:11:08+01:00yannick legocWebsocket for positions publication in Nomad moduleWe can simplify the architecture by defining a websocket for the publication of Nomad positions.
That supposes to open a websocket in the Nomad module on a fixed port.
Then a simple async message can be processed on the node.js side.We can simplify the architecture by defining a websocket for the publication of Nomad positions.
That supposes to open a websocket in the Nomad module on a fixed port.
Then a simple async message can be processed on the node.js side.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/5Application ports in configuration2021-01-27T08:36:17+01:00yannick legocApplication ports in configurationhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/2Node module versions to update2019-10-22T09:31:47+02:00yannick legocNode module versions to updateModules:
- electron: versions >= 5.x remove 'require' keyword, migration of code is necessary. Some root rights also need to be provided:
```
sudo chown root .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
sudo chmod 475...Modules:
- electron: versions >= 5.x remove 'require' keyword, migration of code is necessary. Some root rights also need to be provided:
```
sudo chown root .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
```
- electron-packager: version 14.x is blockinghttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/1Optimize the number of groups2019-05-20T08:45:06+02:00yannick legocOptimize the number of groupsIt is possible to merge groups inside a mergeable block for identical Materials.
Use a map for Material -> set of blocks.It is possible to merge groups inside a mergeable block for identical Materials.
Use a map for Material -> set of blocks.