Nomad 3D issueshttps://code.ill.fr/groups/instrument-control/protos/nomad-3d/-/issues2022-06-09T17:43:54+02:00https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/15Check connection in client2022-06-09T17:43:54+02:00yannick legocCheck connection in clientIt is important to notify the user when the connection is lost (timeout?).It is important to notify the user when the connection is lost (timeout?).https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/14GUI with golden layout2022-03-25T17:23:42+01:00yannick legocGUI with golden layoutSuggestion:
```
|-----------------|----------|
| view 1 | view 2 | settings |
| view 3 | view 4 | |
|----------------------------|
```Suggestion:
```
|-----------------|----------|
| view 1 | view 2 | settings |
| view 3 | view 4 | |
|----------------------------|
```https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/13Use the size of the BB of a component to determine the resolution of VHACD2022-01-11T11:14:19+01:00yannick legocUse the size of the BB of a component to determine the resolution of VHACDhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/12Change the merge criteria to generate more convex parts2022-01-07T15:32:27+01:00yannick legocChange the merge criteria to generate more convex partsTo obtain a better convex decomposition could be done by segmenting into more parts.
Rather than merging into the biggest possible parts (until an axis is found), merge into smaller parts.
The criteria has to be found.To obtain a better convex decomposition could be done by segmenting into more parts.
Rather than merging into the biggest possible parts (until an axis is found), merge into smaller parts.
The criteria has to be found.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-editor/-/issues/7Disallow moving a component in a component that already has a child with the ...2021-11-26T13:08:42+01:00yannick legocDisallow moving a component in a component that already has a child with the same namehttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/11Review what is stored in IndexedDB2021-11-15T16:40:33+01:00yannick legocReview what is stored in IndexedDBThe configuration should not be stored in IndexedDB.The configuration should not be stored in IndexedDB.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-editor/-/issues/6Hidden components reappear after moving some components2021-11-18T16:20:03+01:00yannick legocHidden components reappear after moving some componentsChange in updateScene():
```
Nomad3DEditor.getInstance().setDisplayedRootComponent(Nomad3DEditor.getInstance().getModel().getDisplayedRoot(), keepVisibility = true);
```
Modify resetVisible(...) to have keepVisibility and replace setVi...Change in updateScene():
```
Nomad3DEditor.getInstance().setDisplayedRootComponent(Nomad3DEditor.getInstance().getModel().getDisplayedRoot(), keepVisibility = true);
```
Modify resetVisible(...) to have keepVisibility and replace setVisible(true, true) by keepVisible().https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/10Server performance2021-11-04T09:39:29+01:00yannick legocServer performanceVerify that the requests are executed asynchronously and verify the parallelization of the code e.g. two position requests on two Nomad servers.Verify that the requests are executed asynchronously and verify the parallelization of the code e.g. two position requests on two Nomad servers.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-editor/-/issues/5Edit the Nomad visibility of a component2021-11-03T13:38:37+01:00yannick legocEdit the Nomad visibility of a componentLike Axis, add the possibility to edit the visibility.
Two possible implementations:
- A controller Visible which has a single property visible can be selected. More controllers must be defined in the configuration.
- A couple (controlle...Like Axis, add the possibility to edit the visibility.
Two possible implementations:
- A controller Visible which has a single property visible can be selected. More controllers must be defined in the configuration.
- A couple (controller, boolean property) can be selected.
Then the Nomad 3D Viewer will check the visibility and hide the component if necessary.Cycle 221https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/9Calculate optimized BB in merger2021-04-22T11:19:01+02:00yannick legocCalculate optimized BB in mergerOrient the coordinates of a merge by optimizing the BBOrient the coordinates of a merge by optimizing the BBhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/8StreamDispatcher review2021-04-22T11:17:01+02:00yannick legocStreamDispatcher reviewImprove the StreamDispatcher: add chunk between each data chunk to determine the end or not of the data.Improve the StreamDispatcher: add chunk between each data chunk to determine the end or not of the data.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-sw-addin/-/issues/7Add version in Nomad3DXML node2021-04-21T14:48:59+02:00yannick legocAdd version in Nomad3DXML nodehttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/7Websocket for positions publication in Nomad module2021-11-04T14:11:08+01:00yannick legocWebsocket for positions publication in Nomad moduleWe can simplify the architecture by defining a websocket for the publication of Nomad positions.
That supposes to open a websocket in the Nomad module on a fixed port.
Then a simple async message can be processed on the node.js side.We can simplify the architecture by defining a websocket for the publication of Nomad positions.
That supposes to open a websocket in the Nomad module on a fixed port.
Then a simple async message can be processed on the node.js side.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/6Websocket review2021-03-15T11:54:13+01:00yannick legocWebsocket reviewUse the publish feature of the websocket for the nomad positions.Use the publish feature of the websocket for the nomad positions.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/5Application ports in configuration2021-01-27T08:36:17+01:00yannick legocApplication ports in configurationhttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/4Storage to review2021-03-15T11:56:07+01:00yannick legocStorage to reviewDo not put the configuration nomad endpoint, etc into the storage.
Otherwise in case of change of configuration, the storage must be cleared.Do not put the configuration nomad endpoint, etc into the storage.
Otherwise in case of change of configuration, the storage must be cleared.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/3Manage NomadPositions getSimulatedServerIds() in asynchronous way2021-01-27T08:34:10+01:00yannick legocManage NomadPositions getSimulatedServerIds() in asynchronous wayAppeared in the web branch.Appeared in the web branch.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/2Node module versions to update2019-10-22T09:31:47+02:00yannick legocNode module versions to updateModules:
- electron: versions >= 5.x remove 'require' keyword, migration of code is necessary. Some root rights also need to be provided:
```
sudo chown root .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
sudo chmod 475...Modules:
- electron: versions >= 5.x remove 'require' keyword, migration of code is necessary. Some root rights also need to be provided:
```
sudo chown root .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 .../nomad-3d-viewer/node_modules/electron/dist/chrome-sandbox
```
- electron-packager: version 14.x is blockinghttps://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-viewer/-/issues/1Optimize the number of groups2019-05-20T08:45:06+02:00yannick legocOptimize the number of groupsIt is possible to merge groups inside a mergeable block for identical Materials.
Use a map for Material -> set of blocks.It is possible to merge groups inside a mergeable block for identical Materials.
Use a map for Material -> set of blocks.https://code.ill.fr/instrument-control/protos/nomad-3d/nomad-3d-editor/-/issues/4Run the editor without Nomad connection2021-11-03T13:29:31+01:00yannick legocRun the editor without Nomad connection