Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
Cameo
cameo
Commits
2324f6f4
Commit
2324f6f4
authored
Oct 26, 2020
by
legoc
Browse files
(split) Comment on variable use
parent
0134ec44
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/Application.cpp
View file @
2324f6f4
...
...
@@ -1147,6 +1147,7 @@ std::unique_ptr<Requester> Requester::create(Instance & instance, const std::str
throw
RequesterCreationException
(
response
[
message
::
RequestResponse
::
MESSAGE
].
GetString
());
}
// TODO simplify the use of some variables: responderUrl.
return
unique_ptr
<
Requester
>
(
new
Requester
(
&
This
::
m_instance
,
responderUrl
,
requesterPort
,
responderPort
,
name
,
responderId
,
requesterId
));
}
...
...
src/Server.cpp
View file @
2324f6f4
...
...
@@ -539,6 +539,7 @@ std::unique_ptr<application::Subscriber> Server::createSubscriber(int id, const
int
synchronizerPort
=
response
[
message
::
PublisherResponse
::
SYNCHRONIZER_PORT
].
GetInt
();
int
numberOfSubscribers
=
response
[
message
::
PublisherResponse
::
NUMBER_OF_SUBSCRIBERS
].
GetInt
();
// TODO simplify the use of some variables: e.g. m_serverEndpoint accessible from this.
unique_ptr
<
application
::
Subscriber
>
subscriber
(
new
application
::
Subscriber
(
this
,
publisherPort
,
synchronizerPort
,
publisherName
,
numberOfSubscribers
,
instanceName
,
id
,
m_serverEndpoint
.
toString
(),
m_serverEndpoint
.
withPort
(
m_statusPort
).
toString
()));
subscriber
->
init
();
...
...
Shervin Nourbakhsh
@nourbakhsh
mentioned in commit
46e44691
·
Apr 23, 2021
mentioned in commit
46e44691
mentioned in commit 46e44691a03808a23a464818487b0dd014a9c57e
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment